Refactor handling of invalid ds member names

t1m0thyj commented 3 months ago

What It Does

Improves the way that invalid ds member names are handled. Before we tried to parse the invalid member names and replace control characters with �, which was prone to edge case problems. Now we stop parsing members after the first invalid member name is encountered, and add a fake member entry at the end that says "... N more members" for the ones we are unable to display.

How to Test

Run against our mainframe test system: zowe files ls am {Timothy's PMF key}.COPYBOOK.UNTERSED This data set contains thousands of members with special characters in the name 🙂

Review Checklist

I certify that I have:

[ ] tested my changes
[ ] added/updated automated tests
[ ] updated the changelog
[ ] followed the contribution guidelines

Additional Comments

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 91.05%. Comparing base (9e4a7e7) to head (7b909b5).

Files	Patch %	Lines
packages/zosfiles/src/methods/list/List.ts	83.33%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2104 +/- ## ========================================== - Coverage 91.07% 91.05% -0.02% ========================================== Files 636 636 Lines 19000 19004 +4 Branches 3991 3883 -108 ========================================== + Hits 17304 17305 +1 - Misses 1695 1698 +3 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.