codecov[bot]
commented
2 months ago Codecov Report
Attention: Patch coverage is 99.68051% with 1 lines in your changes are missing coverage. Please review.
Project coverage is 90.96%. Comparing base (
03d99c8) to head (f72d69c). Report is 2 commits behind head on next.
| Files | Patch % | Lines |
|---|---|---|
| ...g/cmd/convert-profiles/convert-profiles.handler.ts | 97.50% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## next #2113 +/- ## ========================================== + Coverage 90.91% 90.96% +0.05% ========================================== Files 616 618 +2 Lines 17376 17473 +97 Branches 3590 3600 +10 ========================================== + Hits 15797 15895 +98 + Misses 1578 1577 -1 Partials 1 1 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
sonarcloud[bot]
github-actions[bot]
What It Does
The new ConvertV1Profiles class enables apps to convert V1 profiles into a current Zowe client configuration file.
The primary function of the
convert profilescommand remains the same. The following changes were introduced:The ConvertV1Profiles.convert API was written to work better for apps that are not a command line program.
How to Test
The impact on end-users can be tested by running the
convert profilescommand in various scenarios. Because V1 profiles can no longer be created in V3, it can be difficult to create useful test data. The following screenshots demonstrate several known scenarios.In a simple situation the output looks like the screenshot below. In this scenario, the V1 SCS plugin was already installed, and the
convert profilescommand uninstalled that plugin.When you also ask to delete your old profiles, you are prompted to confirm the deletion. The output looks like this:
When an error occurs, the output looks like this:
When the old V1 SCS plugin is configured as the CredentialManager for Zowe, the .zowe\settings\imperative.json looks like this:
When configured like this, ALL zowe commands will display a warning that the Credential Manager is not in the list of known credential managers. The command then attempts its operation. An example of a
zowe-files listcommand shows this behavior.Also, when configured like this, the
plugins uninstall @zowe/secure-credential-store-for-zowe-clicommand (like all Zowe commands) displays the same CredentialManager warning. It also display a set of NPM warnings when uninstalling the V1 SCS plugin, even though it successfully uninstalls the SCS plugin.The warnings above are not a result of the
convert profilescommand, but they do affect theconvert profilescommand because:plugins uninstalloperation.Despite the warnings in such a configuration, the
convert profilescommand converts the V1 profiles, uninstalls the SCS plugin, and restores the Zowe built-in CredentialManager.As proof that the
convert profilescommand has restored the built-in CredentialManager, when you now run thezos-files listcommand, you no longer get the CredentialManager warning.Review Checklist I certify that I have:
Additional Comments