search

zowe / zowe-cli

Zowe CLI
Eclipse Public License 2.0
108 stars 85 forks source link

Fix secure properties not listed outside the active config layer #2135

Closed t1m0thyj closed 1 month ago

t1m0thyj commented 1 month ago

What It Does

Fixes https://github.com/zowe/zowe-explorer-vscode/issues/2633

How to Test

Create zowe.config.json and zowe.config.user.json with the contents from https://github.com/zowe/zowe-explorer-vscode/issues/2633#issuecomment-2098383503

Then try to list the secure properties associated with the base profile using the ProfileInfo API:

const { ProfileInfo } = require("@zowe/imperative");

(async () => {
    // Load connection info from default z/OSMF profile
    const profInfo = new ProfileInfo("zowe");
    await profInfo.readProfilesFromDisk();
    console.log(profInfo.getTeamConfig().api.secure.securePropsForProfile("base"));
})();

Review Checklist I certify that I have:

Additional Comments

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.12%. Comparing base (c62e69c) to head (f40e041).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2135 +/- ## ======================================== Coverage 91.12% 91.12% ======================================== Files 636 636 Lines 19035 19035 Branches 3895 4009 +114 ======================================== Hits 17346 17346 Misses 1688 1688 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 1 month ago

Release succeeded for the master branch. :tada:

The following packages have been published:

Powered by Octorelease :rocket: