zowe / zowe-cli

Zowe CLI
Eclipse Public License 2.0
108 stars 85 forks source link

Remove use of deprecated utils functions & Enable deprecation linter #2169

Closed awharn closed 1 week ago

awharn commented 3 weeks ago

What It Does

Stops using deprecated utility functions Changes logic to use require.main over process.mainModule, which is deprecated Enables linters for detecting extra parenthesis and deprecated function use

How to Test

Review Checklist I certify that I have:

Additional Comments

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 91.06628% with 31 lines in your changes missing coverage. Please review.

Project coverage is 91.18%. Comparing base (bbffec2) to head (bf8d8ad). Report is 2 commits behind head on next.

Files Patch % Lines
...ackages/imperative/src/cmd/src/CommandProcessor.ts 80.00% 3 Missing :warning:
...s/imperative/src/cmd/src/syntax/SyntaxValidator.ts 90.62% 3 Missing :warning:
...perative/src/cmd/src/yargs/AbstractCommandYargs.ts 57.14% 3 Missing :warning:
...kages/imperative/src/cmd/src/yargs/CommandYargs.ts 70.00% 3 Missing :warning:
...s/imperative/src/imperative/src/OverridesLoader.ts 50.00% 3 Missing :warning:
...workflows/delete/Delete.archived.common.handler.ts 50.00% 2 Missing :warning:
...src/cmd/src/help/abstract/AbstractHelpGenerator.ts 81.81% 2 Missing :warning:
...es/imperative/src/config/src/ProfileCredentials.ts 66.66% 2 Missing :warning:
...ackages/imperative/src/operations/src/Operation.ts 0.00% 2 Missing :warning:
...ckages/imperative/src/operations/src/Operations.ts 50.00% 2 Missing :warning:
... and 6 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #2169 +/- ## ========================================== - Coverage 91.18% 91.18% -0.01% ========================================== Files 628 628 Lines 17874 17850 -24 Branches 3796 3693 -103 ========================================== - Hits 16299 16276 -23 + Misses 1574 1573 -1 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 week ago

Quality Gate Failed Quality Gate failed

Failed conditions
79.2% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

github-actions[bot] commented 1 week ago

Release succeeded for the next branch. :tada:

The following packages have been published:

Powered by Octorelease :rocket: