zowe / zowe-client-python-sdk

Eclipse Public License 2.0
39 stars 25 forks source link

Fix return value of `Jobs.list_jobs()` to return JSON #251

Closed Myrausman closed 7 months ago

Myrausman commented 7 months ago

What It Does Resolved #27 Jobs.list_jobs() returns json value return json.dumps({"response": response_json})

Review Checklist I certify that I have:

codecov[bot] commented 7 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (09a10d1) 83.83% compared to head (6ba9c17) 83.84%.

Files Patch % Lines
src/zos_jobs/zowe/zos_jobs_for_zowe_sdk/jobs.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #251 +/- ## ======================================= Coverage 83.83% 83.84% ======================================= Files 34 34 Lines 2116 2117 +1 ======================================= + Hits 1774 1775 +1 Misses 342 342 ``` | [Flag](https://app.codecov.io/gh/zowe/zowe-client-python-sdk/pull/251/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zowe) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/zowe/zowe-client-python-sdk/pull/251/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zowe) | `83.84% <50.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zowe#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zFernand0 commented 7 months ago

Hey @Myrausman, There are a few commits that need signed off (or perhaps removed from the history) 😋 Here are some steps that may help:


Regarding:

zFernand0 should i update changelog as well ?

Yeah, I think it'd be good to have an entry for this fix 😋