search

zowe / zowe-client-python-sdk

Eclipse Public License 2.0
36 stars 26 forks source link

Convert windows line ending and previous PR #276

Closed pem70 closed 2 weeks ago

pem70 commented 3 weeks ago

What It Does Fixes [#104] Address issues [#264] and [#265] by refactoring classes and tests

How to Test

Review Checklist I certify that I have:

Additional Comments

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 93.06931% with 63 lines in your changes missing coverage. Please review.

Project coverage is 89.28%. Comparing base (5816aab) to head (95ac994).

Files Patch % Lines
.../zos_files/zowe/zos_files_for_zowe_sdk/datasets.py 88.42% 25 Missing :warning:
src/zos_files/zowe/zos_files_for_zowe_sdk/uss.py 66.10% 20 Missing :warning:
src/zos_files/zowe/zos_files_for_zowe_sdk/files.py 78.26% 10 Missing :warning:
...s_files/zowe/zos_files_for_zowe_sdk/file_system.py 90.00% 5 Missing :warning:
tests/unit/core/test_config.py 96.07% 2 Missing :warning:
src/core/zowe/core_for_zowe_sdk/profile_manager.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #276 +/- ## ========================================== + Coverage 86.21% 89.28% +3.06% ========================================== Files 35 53 +18 Lines 2292 2519 +227 ========================================== + Hits 1976 2249 +273 + Misses 316 270 -46 ``` | [Flag](https://app.codecov.io/gh/zowe/zowe-client-python-sdk/pull/276/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zowe) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/zowe/zowe-client-python-sdk/pull/276/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zowe) | `89.28% <93.06%> (+3.06%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zowe#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pem70 commented 3 weeks ago

Revert changes from previous commit as it would break testing environments.