zowe / zowe-client-python-sdk

Eclipse Public License 2.0
36 stars 26 forks source link

Standardize response #285

Closed pem70 closed 1 week ago

pem70 commented 2 weeks ago

What It Does addresses [#266]

How to Test

Review Checklist I certify that I have:

Additional Comments

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.37%. Comparing base (8ac7348) to head (f02124b).

Files Patch % Lines
src/zos_jobs/zowe/zos_jobs_for_zowe_sdk/jobs.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #285 +/- ## ========================================== + Coverage 89.27% 89.37% +0.10% ========================================== Files 53 53 Lines 2536 2542 +6 ========================================== + Hits 2264 2272 +8 + Misses 272 270 -2 ``` | [Flag](https://app.codecov.io/gh/zowe/zowe-client-python-sdk/pull/285/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zowe) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/zowe/zowe-client-python-sdk/pull/285/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zowe) | `89.37% <90.00%> (+0.10%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zowe#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zFernand0 commented 2 weeks ago

As a test, I went ahead and changed the base of this PR, and it seemed to have cleaned up a lot of the commits 😋 Should we keep it with the TSO branch as the base, or would you prefer for this PR to be rebased back to main?

@pem70, @t1m0thyj, and @traeok, any thoughts?

traeok commented 2 weeks ago

...@traeok, any thoughts?

I think it makes sense to keep the base branch as TSO, if it makes it easier to get everything merged into main 😋