CI: Codecov failing when uploading coverage

zowe / zowe-client-python-sdk

Eclipse Public License 2.0

36 stars 26 forks source link

CI: Codecov failing when uploading coverage #290

Closed zFernand0 closed 6 days ago

zFernand0 commented 1 week ago

Describe the bug

We might want to double check to see if the coverage results were uploaded from another OS/Version combination.

Expected and actual results

Expected the win/mac 3.12 pipeline to succeed 😋

Describe your environment

GHA

Additional context

github-actions[bot] commented 1 week ago

Thank you for creating a bug report. We will investigate the bug and evaluate its impact on the product. If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

JTonda commented 6 days ago

Investigate the latest documentation for codecov. Decide whether to fix the multiplatform or switch to just one. Do this across all CLI & ZE repos.

t1m0thyj commented 6 days ago

The CodeCov action is failing only on some PRs:

When opened by Dependabot like https://github.com/zowe/zowe-client-python-sdk/pull/259 - adding token as a Dependabot secret should fix this, see https://github.com/codecov/codecov-action/issues/1463#issuecomment-2161292128
When opened from a fork like https://github.com/zowe/zowe-client-python-sdk/pull/283 - no longer supported since pull_request workflows don't have access to repository secrets, see https://github.com/codecov/codecov-action/issues/1469

t1m0thyj commented 6 days ago

Codecov token has been added as a Dependabot secret:

For PRs opened from a fork, Codecov released an enhancement just last week to support tokenless upload in this case: https://github.com/codecov/codecov-action/pull/1410. Here is an example of PR where this is working: https://github.com/zowe/zowe-client-python-sdk/pull/294 The PR is happening in a forked repo. Using tokenless upload.