zowe / zowe-client-python-sdk

Eclipse Public License 2.0
39 stars 26 forks source link

vault: Values stored securely take precedence over plain-text #311

Open zFernand0 opened 1 month ago

zFernand0 commented 1 month ago

Describe the bug

Assuming the following vault contents and the config file below...


Vault contents ```json { "/path/to/$pwd/zowe.config.json": { "profiles.base.properties.certFile": "old_cert.pem", "profiles.base.properties.certKeyFile": "old_key.pem" } } ``` **Note:** The contents above are base64 enconded in the vault
Actual contents ``` eyIvcGF0aC90by8kcHdkL3pvd2UuY29uZmlnLmpzb24iOnsicHJvZmlsZXMuYmFzZS5wcm9wZXJ0aWVzLmNlcnRGaWxlIjoib2xkX2NlcnQucGVtIiwicHJvZmlsZXMuYmFzZS5wcm9wZXJ0aWVzLmNlcnRLZXlGaWxlIjoib2xkX2tleS5wZW0ifX0= ```

Config file ```json { "$schema": "./zowe.schema.json", "profiles": { "zosmf": { "type": "zosmf", "properties": { "port": 443, "rejectUnauthorized": false }, "secure": [] }, "base": { "type": "base", "properties": { "host": "my_lpar.net", "certFile": "crt.pem", "certKeyFile": "key.pem"}, "secure": [] } }, "defaults": { "zosmf": "zosmf", "base": "base" }, "autoStore": true } ```

Expected and actual results

I would expect the python SDK to use the contents of the zowe.config.json as it is at the time of executing the script.

Instead, it is using the old_cert and old_key (from the vault)

Describe your environment

Py: 3.12.4 Pip: 24.0 Terminal: Zsh Env: N/A

Additional context

Found this while testing #305

github-actions[bot] commented 1 month ago

Thank you for creating a bug report. We will investigate the bug and evaluate its impact on the product. If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.