zowe / zowe-common-c

C Libraries for various OS & Networking needs
Eclipse Public License 2.0
10 stars 30 forks source link

Debug option excess spam #463

Open nosrednayduj opened 4 months ago

nosrednayduj commented 4 months ago

Describe the bug If you specify components.zss.logLevels._zss.httpserver: 5 then you get dozens of lines, tokenEnd=8 tokenEnd=9 .... tokenEnd=956 tokenEnd=957 (or however long your token is)

Looks to me like this line should be moved OUTSIDE the loop!

https://github.com/zowe/zowe-common-c/blob/194623a65f095a2ae57c67c11d79992a0ec0e4a5/c/httpserver.c#L2916

Steps to Reproduce

  1. enable debug components.zss.logLevels._zss.httpserver: 5
  2. hit ZSS with some web requests using token authentication

Expected behavior

Only one line of tokenEnd, however long the token is.

Logs see snippet above

Describe your environment

Additional context Had occasion to enable this debug. If your token is short it's not too bad (e.g. token 40 chars) but some of the tokens are really long if they come from APIML.

nosrednayduj commented 4 months ago

Another place, same problem, end note is inside loop. https://github.com/zowe/zowe-common-c/blob/194623a65f095a2ae57c67c11d79992a0ec0e4a5/c/httpserver.c#L2849