search

zowe / zowe-explorer-vscode

Visual Studio Code Extension for Zowe, which lets users interact with z/OS Data Sets, Unix System Services, and Jobs on a remote mainframe instance. Powered by Zowe SDKs.
Eclipse Public License 2.0
169 stars 91 forks source link

getSpoolContentById not converted with proper character encoding #2683

Open JillieBeanSim opened 8 months ago

JillieBeanSim commented 8 months ago

Describe the bug

viewing spool files in Zowe Explorer jobs view is not converting with proper encoding from what I see the zosmf cli call takes the session which should have the profile's encoding but doesn't seem to be used zowe.GetJobs.getSpoolContentById(this.getSession(), jobname, jobid, spoolId) looking at the zosmf rest api swagger the GET /records accepts a fileEncoding value Screenshot 2024-01-24 at 10 31 01 AM

Expected behavior

profile encoding to be supported when downloading content of spool files and the file is converted correctly

Screenshots

Desktop (please complete the following information):

Additional context

github-actions[bot] commented 8 months ago

Thank you for creating a bug report. We will investigate the bug and evaluate its impact on the product. If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

JillieBeanSim commented 8 months ago

Depends on cli issue https://github.com/zowe/zowe-cli/issues/876

t1m0thyj commented 8 months ago

This is blocked by https://github.com/zowe/zowe-cli/pull/1822

We have already done the work on the Zowe client side to enable codepages for spool files, but the PR is still in draft mode because we have a ticket open with IBM regarding the z/OSMF encoding option not working as expected.

awharn commented 4 months ago

This is now unblocked as of Zowe CLI/SDKs 7.25.0