zowe / zowe-explorer-vscode

Visual Studio Code Extension for Zowe, which lets users interact with z/OS Data Sets, Unix System Services, and Jobs on a remote mainframe instance. Powered by Zowe SDKs.
Eclipse Public License 2.0
159 stars 89 forks source link

Merge maintenance to main #2840

Closed JillieBeanSim closed 2 months ago

JillieBeanSim commented 2 months ago

Proposed changes

Merge maintenance to main, with audit fix

Release Notes

Milestone: n/a

Changelog: n/a

Types of changes

What types of changes does your code introduce to Zowe Explorer? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

Further comments

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 94.44444% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 93.32%. Comparing base (62cdb6e) to head (6989657).

Files Patch % Lines
packages/zowe-explorer/src/shared/init.ts 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2840 +/- ## ========================================== - Coverage 93.33% 93.32% -0.01% ========================================== Files 103 103 Lines 10693 10703 +10 Branches 2241 2334 +93 ========================================== + Hits 9980 9989 +9 - Misses 712 713 +1 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

t1m0thyj commented 2 months ago

Looks like Theia tests are failing but that's not unique to this PR - looking into it on #2838

zFernand0 commented 2 months ago

Thanks for porting the changes over to main! 🥳

t1m0thyj commented 2 months ago

@JillieBeanSim I think Theia tests should be fixed by this commit if you want to cherry-pick it 😋 https://github.com/zowe/zowe-explorer-vscode/pull/2838/commits/2d96793c3c4de79a6b0190378b621571b9591857

On the other PR I updated to a newer version of the Theia Docker image, which caused additional test failures that I'm still looking into

sonarcloud[bot] commented 2 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
14.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud