Give user option to upload files as binary in USS tree

likhithanimma1 commented 5 months ago

Proposed changes

Provide users with the option to upload binary files by implementing a "Upload Files (Binary)" right-click option in the USS tree.

Release Notes

Milestone:

Changelog:

Types of changes

What types of changes does your code introduce to Zowe Explorer? Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

[ ] I have read the CONTRIBUTOR GUIDANCE wiki
[ ] PR title follows Conventional Commits Guidelines
[x] PR Description is included
[ ] gif or screenshot is included if visual changes are made
[x] yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
[ ] All checks have passed (DCO, Jenkins and Code Coverage)
[x] I have added unit test and it is passing
[ ] I have added integration test and it is passing
[ ] There is coverage for the code that I have added
[ ] I have tested it manually and there are no regressions found
[ ] I have added necessary documentation (if appropriate)
[ ] Any PR dependencies have been merged and published (if appropriate)

Further comments

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.32%. Comparing base (8cd2da0) to head (ff874a1).

Files	Patch %	Lines
packages/zowe-explorer/src/uss/actions.ts	90.47%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2848 +/- ## ========================================== - Coverage 93.33% 93.32% -0.02% ========================================== Files 103 103 Lines 10727 10740 +13 Branches 2341 2254 -87 ========================================== + Hits 10012 10023 +11 - Misses 714 716 +2 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

traeok commented 5 months ago

I was looking around and found #1956 - I think this PR will implement the request from that issue 👍 Maybe we should reference that issue in the changelog entry as well?

likhithanimma1 commented 5 months ago

Thanks for working on this enhancement @likhithanimma1!

I noticed that two status bar messages appear at the same time as the upload:

"Uploading file to USS tree"

"Upload action was cancelled"

After the "Uploading file..." message disappears, it seems the file was not successfully uploaded as I cannot fetch the file in the destination folder afterward:

Addressed the behaviour!

JillieBeanSim commented 5 months ago

Thanks for addressing the withProgress and tree refresh, this is looking good. I did experience the same issue seen as Trae with the filename missing from delete dialog but only with the upload of binary, same scenario works fine with regular upload.

likhithanimma1 commented 5 months ago

Thanks for addressing the withProgress and tree refresh, this is looking good. I did experience the same issue seen as Trae with the filename missing from delete dialog but only with the upload of binary, same scenario works fine with regular upload.

Addressed deletion of files after uploading @JillieBeanSim