zowe / zowe-explorer-vscode

Visual Studio Code Extension for Zowe, which lets users interact with z/OS Data Sets, Unix System Services, and Jobs on a remote mainframe instance. Powered by Zowe SDKs.
Eclipse Public License 2.0
159 stars 89 forks source link

[v3] ci: lock pnpm version to 9 #2852

Closed traeok closed 2 months ago

traeok commented 2 months ago

Proposed changes

Locks the pnpm version in CI to v9.

Release Notes

Milestone:

Changelog:

Types of changes

What types of changes does your code introduce to Zowe Explorer? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

traeok commented 2 months ago

Turns out that pnpm v9.0.1 was released and it didn't propagate to the runners until some time after this commit was pushed/tested. It resolved an issue where pnpm install failed in CI when the lockfile could be changed. If it's okay with the team, I'd like to update this to lock the version to pnpm@9, as it would be consistent w/ other Zowe repos that lock the major version of the package manager (such as the CLI).