fix(commands): Hide commands from palette that require nodes/info

traeok commented 2 months ago

Proposed changes

Hides the following commands from the Command Palette as they do not function properly without a node or other arguments:

Zowe Explorer: Cancel job
Zowe Explorer: Filter jobs
Zowe Explorer: Filter PDS members
Zowe Explorer: Sort jobs
Zowe Explorer: Sort PDS members
Zowe Explorer: Start Polling
Zowe Explorer: Stop Polling

If we want to add support for running some of these commands in the Command Palette, I'll file an issue to track those. For now, it's best to hide these so users don't try to run them, as there isn't any error handling in place - so any errors will show in a modal dialog. Thanks to @awharn for spotting some of these during our offline discussion 🙂

Release Notes

Milestone: 2.16.0 (or 2.15.3 if we want to release another patch, whichever is preferred)

Changelog:

Types of changes

What types of changes does your code introduce to Zowe Explorer? Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

[x] I have read the CONTRIBUTOR GUIDANCE wiki
[x] PR title follows Conventional Commits Guidelines
[x] PR Description is included
[ ] gif or screenshot is included if visual changes are made
[x] yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
[ ] All checks have passed (DCO, Jenkins and Code Coverage)
[ ] I have added unit test and it is passing
[ ] I have added integration test and it is passing
[ ] There is coverage for the code that I have added
[x] I have tested it manually and there are no regressions found

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.33%. Comparing base (ce96759) to head (f33b391). Report is 8 commits behind head on main.

:exclamation: Current head f33b391 differs from pull request most recent head a4b9918. Consider uploading reports for the commit a4b9918 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2853 +/- ## ======================================= Coverage 93.33% 93.33% ======================================= Files 103 103 Lines 10724 10724 Branches 2320 2336 +16 ======================================= Hits 10009 10009 Misses 714 714 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.