zowe / zowe-explorer-vscode

Visual Studio Code Extension for Zowe, which lets users interact with z/OS Data Sets, Unix System Services, and Jobs on a remote mainframe instance. Powered by Zowe SDKs.
Eclipse Public License 2.0
159 stars 89 forks source link

fix(config): Log schema warnings instead of UI warning message #2860

Closed traeok closed 2 months ago

traeok commented 2 months ago

Proposed changes

Since developers and extenders are the primary users to inform when schema warnings occur, I figured it was best to move this into the log file for now until an "error code" is added to the schema management return values. Once that is available we can choose to show UI messages for specific scenarios - currently, I would have to implement hardcoded checks against error messages and I don't think that is a viable solution.

Release Notes

Milestone:

Changelog:

Types of changes

What types of changes does your code introduce to Zowe Explorer? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.43%. Comparing base (93270d0) to head (4c30ca8). Report is 1 commits behind head on maintenance.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## maintenance #2860 +/- ## =============================================== - Coverage 93.44% 93.43% -0.01% =============================================== Files 103 103 Lines 10675 10675 Branches 2324 2324 =============================================== - Hits 9975 9974 -1 - Misses 699 700 +1 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud