Fix #2484: Added Status bar to indicate data is being pulled from mainframe.

Ash-2k3 commented 2 months ago

Proposed changes

This PR addresses issue https://github.com/zowe/zowe-explorer-vscode/issues/2484. I began by searching the codebase for the string "Pull from Mainframe" and found the associated keys "refreshDataset", "uss.refreshUSS", and "jobs.refreshSpool". This led me to the relevant code sections, where I determined that these keys trigger commands responsible for pulling data from the mainframe in different contexts. I added status bar indicators within the corresponding command handlers in the init.ts file to provide users with visual feedback during "Pull from Mainframe" operations.

Release Notes

Milestone:

Changelog: Added Status bar to indicate that data is being pulled from mainframe.

Types of changes

What types of changes does your code introduce to Zowe Explorer? Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

[x] I have read the CONTRIBUTOR GUIDANCE wiki
[x] PR title follows Conventional Commits Guidelines
[x] PR Description is included
[ ] gif or screenshot is included if visual changes are made
[x] yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
[ ] All checks have passed (DCO, Jenkins and Code Coverage)
[ ] I have added unit test and it is passing
[ ] I have added integration test and it is passing
[ ] There is coverage for the code that I have added
[ ] I have tested it manually and there are no regressions found
[ ] I have added necessary documentation (if appropriate)
[ ] Any PR dependencies have been merged and published (if appropriate)

Further comments

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.48%. Comparing base (2f5b3d7) to head (dbbaab9).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2865 +/- ## ========================================== + Coverage 93.47% 93.48% +0.01% ========================================== Files 103 103 Lines 10750 10768 +18 Branches 2338 2347 +9 ========================================== + Hits 10049 10067 +18 Misses 700 700 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Ash-2k3 commented 2 months ago

One test is failing and I am not sure how it's supposed to fix. (https://github.com/zowe/zowe-explorer-vscode/actions/runs/8784312920/job/24102290328?pr=2865)

Is it related to filling up the changelog section of Release Notes ?

t1m0thyj commented 2 months ago

One test is failing and I am not sure how it's supposed to fix. (https://github.com/zowe/zowe-explorer-vscode/actions/runs/8784312920/job/24102290328?pr=2865)

Is it related to filling up the changelog section of Release Notes ?

@Ash-2k3 Yes, please add a line to the changelog in the "TBD Release > Bug Fixes" section and include a link to the issue number 🙂

Ash-2k3 commented 2 months ago

One test is failing and I am not sure how it's supposed to fix. (https://github.com/zowe/zowe-explorer-vscode/actions/runs/8784312920/job/24102290328?pr=2865) Is it related to filling up the changelog section of Release Notes ?

@Ash-2k3 Yes, please add a line to the changelog in the "TBD Release > Bug Fixes" section and include a link to the issue number 🙂

Alright, thanks for letting me know. One question: Isn't this more of a enhancement rather than being a bug fix ? I think I would prefer to add it in "New features and enhancements" section. WDYT ?

Ash-2k3 commented 2 months ago

I have added a line to the "TBD release > New features and enhancements" section for now. Please lmk if it needs to be changed, Thanks :)