zowe / zowe-explorer-vscode

Visual Studio Code Extension for Zowe, which lets users interact with z/OS Data Sets, Unix System Services, and Jobs on a remote mainframe instance. Powered by Zowe SDKs.
Eclipse Public License 2.0
159 stars 89 forks source link

Added the ability to switch between basic authentication and token-based authentication #2867

Closed SanthoshiBoyina closed 3 weeks ago

SanthoshiBoyina commented 2 months ago

Proposed changes

Added the ability to switch between basic authentication and token-based authentication.

Release Notes

Milestone:

Changelog:

Types of changes

What types of changes does your code introduce to Zowe Explorer? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

Further comments

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 90.19608% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.47%. Comparing base (560b857) to head (a931e3d).

Files Patch % Lines
packages/zowe-explorer/src/Profiles.ts 91.11% 4 Missing :warning:
...kages/zowe-explorer/src/utils/ProfileManagement.ts 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2867 +/- ## ========================================== - Coverage 93.49% 93.47% -0.03% ========================================== Files 104 104 Lines 10890 10941 +51 Branches 2382 2383 +1 ========================================== + Hits 10182 10227 +45 - Misses 707 713 +6 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JillieBeanSim commented 1 month ago

I recorded some videos of what I am seeing with this branch

https://github.com/zowe/zowe-explorer-vscode/assets/49491949/b95ca139-256c-4818-a269-8aec4b57c26d

https://github.com/zowe/zowe-explorer-vscode/assets/49491949/b11841a3-50c8-4030-ba0d-632d2a33a47c

SanthoshiBoyina commented 1 month ago

I fell into a bit of a circular issue with login to API ML where login was successful and token written correctly then the connection no longer active message showed, when clicking the button I re-login again and it wrote the tokenType & tokenValue to the zosmf profile. very strange behavior Screenshot 2024-05-02 at 7 53 03 AM

Screenshot 2024-05-02 at 7 53 42 AM

Can you check by adding port number 7554 to the base profile?

JillieBeanSim commented 1 month ago

I fell into a bit of a circular issue with login to API ML where login was successful and token written correctly then the connection no longer active message showed, when clicking the button I re-login again and it wrote the tokenType & tokenValue to the zosmf profile. very strange behavior Screenshot 2024-05-02 at 7 53 03 AM Screenshot 2024-05-02 at 7 53 42 AM

Can you check by adding port number 7554 to the base profile?

Hey @SanthoshiBoyina, we should be able to handle either instance of port location for the action.

zFernand0 commented 1 month ago

It's possible that reviewers might run into this issue: (re: multiple layers)

sonarcloud[bot] commented 4 weeks ago

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
14.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

JillieBeanSim commented 3 weeks ago

Hey @SanthoshiBoyina we are seeing another PR with same name as this, https://github.com/zowe/zowe-explorer-vscode/pull/2944. Should this be closed in favor of newer PR?

SanthoshiBoyina1 commented 3 weeks ago

Hey @SanthoshiBoyina we are seeing another PR with same name as this, #2944. Should this be closed in favor of newer PR?

Yes @JillieBeanSim, this PR can be closed in favour of PR #2944.