Closed SanthoshiBoyina closed 3 weeks ago
Attention: Patch coverage is 90.19608%
with 5 lines
in your changes missing coverage. Please review.
Project coverage is 93.47%. Comparing base (
560b857
) to head (a931e3d
).
Files | Patch % | Lines |
---|---|---|
packages/zowe-explorer/src/Profiles.ts | 91.11% | 4 Missing :warning: |
...kages/zowe-explorer/src/utils/ProfileManagement.ts | 83.33% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I recorded some videos of what I am seeing with this branch
https://github.com/zowe/zowe-explorer-vscode/assets/49491949/b95ca139-256c-4818-a269-8aec4b57c26d
https://github.com/zowe/zowe-explorer-vscode/assets/49491949/b11841a3-50c8-4030-ba0d-632d2a33a47c
I fell into a bit of a circular issue with login to API ML where login was successful and token written correctly then the connection no longer active message showed, when clicking the button I re-login again and it wrote the tokenType & tokenValue to the zosmf profile. very strange behavior
Can you check by adding port number 7554 to the base profile?
I fell into a bit of a circular issue with login to API ML where login was successful and token written correctly then the connection no longer active message showed, when clicking the button I re-login again and it wrote the tokenType & tokenValue to the zosmf profile. very strange behavior
![]()
Can you check by adding port number 7554 to the base profile?
Hey @SanthoshiBoyina, we should be able to handle either instance of port location for the action.
It's possible that reviewers might run into this issue: (re: multiple layers)
Failed conditions
2 Security Hotspots
14.2% Duplication on New Code (required ≤ 3%)
Hey @SanthoshiBoyina we are seeing another PR with same name as this, https://github.com/zowe/zowe-explorer-vscode/pull/2944. Should this be closed in favor of newer PR?
Hey @SanthoshiBoyina we are seeing another PR with same name as this, #2944. Should this be closed in favor of newer PR?
Yes @JillieBeanSim, this PR can be closed in favour of PR #2944.
Proposed changes
Added the ability to switch between basic authentication and token-based authentication.
Release Notes
Milestone:
Changelog:
Types of changes
What types of changes does your code introduce to Zowe Explorer? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments