fix(ds): resolve TypeError when expanding favorited PDS

traeok commented 2 months ago

Proposed changes

Resolves the issue where expanding a PDS member results in a TypeError. The logic for getSessionNode was updated for 2.15.3 and now returns the proper node for favorited items. However, due to this change, the sorting logic needs an adjustment to define the sort property for sessions under the Favorites folder.

Release Notes

Milestone: 2.15.4

Changelog:

Fixed issue where expanding a favorited PDS resulted in an error message.

Types of changes

What types of changes does your code introduce to Zowe Explorer? Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

[x] I have read the CONTRIBUTOR GUIDANCE wiki
[x] PR title follows Conventional Commits Guidelines
[x] PR Description is included
[ ] gif or screenshot is included if visual changes are made
[x] yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
[ ] All checks have passed (DCO, Jenkins and Code Coverage)
[ ] I have added unit test and it is passing
[ ] I have added integration test and it is passing
[ ] There is coverage for the code that I have added
[x] I have tested it manually and there are no regressions found

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.45%. Comparing base (bbe879d) to head (61d1ca3). Report is 7 commits behind head on maintenance.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## maintenance #2874 +/- ## ============================================ Coverage 93.45% 93.45% ============================================ Files 103 103 Lines 10678 10678 Branches 2320 2307 -13 ============================================ Hits 9979 9979 Misses 698 698 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.