Closed t1m0thyj closed 2 months ago
Attention: Patch coverage is 97.56098%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 93.48%. Comparing base (
c47fdf7
) to head (46f5dc0
). Report is 8 commits behind head on maintenance.:exclamation: Current head 46f5dc0 differs from pull request most recent head 213e75a. Consider uploading reports for the commit 213e75a to get more accurate results
Files | Patch % | Lines |
---|---|---|
packages/zowe-explorer/src/uss/ZoweUSSNode.ts | 75.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Failed conditions
30.8% Duplication on New Code (required ≤ 3%)
was getting ready to merge then seen it was against maintenance branch, @t1m0thyj I thought you mentioned rebasing to main on Tues call?
I see PR to merge main into maintenance, we will want to make sure to re-port back to main if this goes directly into maintenance to avoid loosing the change.
Proposed changes
Fixes #2696 by adding a prompt to download data sets in binary mode similar to the existing behavior for USS files.
Release Notes
Milestone: 2.16.0
Changelog: Fixed issue where data sets or members containing binary content cannot be opened
Types of changes
What types of changes does your code introduce to Zowe Explorer? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments