zowe / zowe-explorer-vscode

Visual Studio Code Extension for Zowe, which lets users interact with z/OS Data Sets, Unix System Services, and Jobs on a remote mainframe instance. Powered by Zowe SDKs.
Eclipse Public License 2.0
159 stars 89 forks source link

fix(ds): Support opening data sets in binary mode #2882

Closed t1m0thyj closed 2 months ago

t1m0thyj commented 2 months ago

Proposed changes

Fixes #2696 by adding a prompt to download data sets in binary mode similar to the existing behavior for USS files.

Release Notes

Milestone: 2.16.0

Changelog: Fixed issue where data sets or members containing binary content cannot be opened

Types of changes

What types of changes does your code introduce to Zowe Explorer? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

Further comments

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 97.56098% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 93.48%. Comparing base (c47fdf7) to head (46f5dc0). Report is 8 commits behind head on maintenance.

:exclamation: Current head 46f5dc0 differs from pull request most recent head 213e75a. Consider uploading reports for the commit 213e75a to get more accurate results

Files Patch % Lines
packages/zowe-explorer/src/uss/ZoweUSSNode.ts 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## maintenance #2882 +/- ## =============================================== + Coverage 93.45% 93.48% +0.02% =============================================== Files 103 103 Lines 10679 10678 -1 Branches 2306 2241 -65 =============================================== + Hits 9980 9982 +2 + Misses 698 695 -3 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 2 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
30.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

JillieBeanSim commented 2 months ago

was getting ready to merge then seen it was against maintenance branch, @t1m0thyj I thought you mentioned rebasing to main on Tues call?

I see PR to merge main into maintenance, we will want to make sure to re-port back to main if this goes directly into maintenance to avoid loosing the change.