search

zowe / zowe-explorer-vscode

Visual Studio Code Extension for Zowe, which lets users interact with z/OS Data Sets, Unix System Services, and Jobs on a remote mainframe instance. Powered by Zowe SDKs.
Eclipse Public License 2.0
159 stars 89 forks source link

merge: 2.16 changes -> `maintenance` #2891

Closed traeok closed 1 month ago

traeok commented 2 months ago

Proposed changes

Merges the recent changes from main into maintenance.

TODO:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 93.68030% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 93.49%. Comparing base (575a6e3) to head (bcce968).

Files Patch % Lines
...kages/zowe-explorer/src/utils/CertificateWizard.ts 90.19% 5 Missing :warning:
...kages/zowe-explorer/src/dataset/ZoweDatasetNode.ts 92.68% 3 Missing :warning:
...owe-explorer-api/src/vscode/ZoweVsCodeExtension.ts 91.30% 2 Missing :warning:
...xplorer-ftp-extension/src/ZoweExplorerFtpJesApi.ts 0.00% 2 Missing :warning:
packages/zowe-explorer/src/uss/actions.ts 90.47% 2 Missing :warning:
packages/zowe-explorer/src/dataset/actions.ts 92.30% 1 Missing :warning:
packages/zowe-explorer/src/job/ZoweJobNode.ts 92.85% 1 Missing :warning:
packages/zowe-explorer/src/utils/ProfilesUtils.ts 96.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## maintenance #2891 +/- ## =============================================== + Coverage 93.48% 93.49% +0.01% =============================================== Files 103 104 +1 Lines 10678 10840 +162 Branches 2241 2365 +124 =============================================== + Hits 9982 10135 +153 - Misses 695 704 +9 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JillieBeanSim commented 2 months ago

@traeok if this is in prep of 2.16.0 code freeze, can this be changed to a draft until the PRs against main for 2.16.0 are merged and this is updated with all?

zFernand0 commented 2 months ago

Dumb question: If main is up to date with maintenance, why not just remove+recreate (or rebase) the maintenance branch?

traeok commented 2 months ago

Dumb question: If main is up to date with maintenance, why not just remove+recreate (or rebase) the maintenance branch?

I would be in favor of rebasing or removing/recreating maintenance, but wasn't sure if the squad would be okay with that, so I went with the usual merge process this time around 👍

sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
7.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud