Fix Coverity code smells in v3

t1m0thyj commented 2 months ago

Proposed changes

Fixes 4 code smells detected by Coverity in the v3 branch

Release Notes

Milestone:

Changelog:

Types of changes

What types of changes does your code introduce to Zowe Explorer? Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

[ ] I have read the CONTRIBUTOR GUIDANCE wiki
[ ] PR title follows Conventional Commits Guidelines
[ ] PR Description is included
[ ] gif or screenshot is included if visual changes are made
[ ] yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
[ ] All checks have passed (DCO, Jenkins and Code Coverage)
[ ] I have added unit test and it is passing
[ ] I have added integration test and it is passing
[ ] There is coverage for the code that I have added
[ ] I have tested it manually and there are no regressions found
[ ] I have added necessary documentation (if appropriate)
[ ] Any PR dependencies have been merged and published (if appropriate)

Further comments

sonarcloud[bot] commented 2 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.40%. Comparing base (cb6aba7) to head (de7b9dc). Report is 1 commits behind head on next.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## next #2896 +/- ## ========================================== + Coverage 93.38% 93.40% +0.02% ========================================== Files 121 121 Lines 10835 10834 -1 Branches 2309 2310 +1 ========================================== + Hits 10118 10120 +2 + Misses 714 712 -2 + Partials 3 2 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zFernand0 commented 2 months ago

I don't think we have an open issue for addressing scan results in general, but I think this is a good practice to continue doing.

@t1m0thyj, Should we open an issue about the settingEnabled bug that was theoretically fixed here? Not sure if we really need it, but it might be good to capture it somewhere 😋

JillieBeanSim commented 2 months ago

merging with the approvals. also for follow up @t1m0thyj, here is the issue I mentioned in scrum that may be related https://github.com/zowe/zowe-explorer-vscode/issues/2063

zowe / zowe-explorer-vscode