zowe / zowe-explorer-vscode

Visual Studio Code Extension for Zowe, which lets users interact with z/OS Data Sets, Unix System Services, and Jobs on a remote mainframe instance. Powered by Zowe SDKs.
Eclipse Public License 2.0
159 stars 89 forks source link

Zowe Explorer to use VS Code Log Level for built in enhancements #2907

Open JillieBeanSim opened 1 month ago

JillieBeanSim commented 1 month ago

born from issue: https://github.com/zowe/zowe-explorer-vscode/issues/2271 vs code related issue: https://github.com/microsoft/vscode/issues/170450

VS Code now allows extenders Output Channel to have a log level setting control to change the level at a whim or save the new as default, removing the need to go directly into the settings to make the change. This is only available for extenders if they use the VS Code log level enum, per related issue.

This would be a really nice feature to have with our extension but would be considered a breaking change and would need to be done either in v3 or another major release.

Screenshot 2024-05-08 at 8 53 41 AM

VS Code log level setting can be accessed via Command Palette

Screenshot 2024-05-08 at 9 00 28 AM
github-actions[bot] commented 1 month ago

Thank you for raising this enhancement request. The community has 90 days to vote on it. If the enhancement receives at least 10 upvotes, it is added to our development backlog. If it receives fewer votes, the issue is closed.

JTonda commented 1 month ago

Research Items:

JillieBeanSim commented 2 weeks ago

I did some investigation and it looks like we can only bring this in on the next branch, this is not necessarily due to expected breaking changes but due to the availability of the vscode.logOutputChannel type introduced in 1.74. Played a little but don't have full support with change reflecting

Screenshot 2024-06-13 at 10 19 29 AM

Started a branch with this work so far, very early stages

JillieBeanSim commented 1 week ago

If we decide to do this it will be a breaking change as we cannot set the vscode.LogLevel to make it work with the existing setting, it is a readonly property. We can adopt it but at the cost of ditching our own setting and fully relying on the VSC setting? This will also mean dropping the support to have CLI and VSC log level match if user chooses. The request to VSC to make this editable was closed as not planned https://github.com/microsoft/vscode/issues/170450.

Image