port(v2): Unsaved confirmation dialog for "Open with Encoding" feature

traeok commented 1 month ago

Proposed changes

Backport of the confirmation dialog shown for "Open with Encoding" when trying to change the encoding on an unsaved file.

Note: currently this only reverts the active editor. I'm still looking for a solution that will allow us to revert an editor that isn't active but is open - if anyone is aware of one please let me know 😋

In v3 we use the vscode.window.tabGroups approach to look for an editor in all open tabs, but this is not supported for VS Code versions older than v1.65.

Release Notes

Milestone: 2.17.0

Changelog:

Added a confirmation dialog when the encoding is changed for an unsaved data set or USS file. #2911

Types of changes

What types of changes does your code introduce to Zowe Explorer? Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

[x] I have read the CONTRIBUTOR GUIDANCE wiki
[x] PR title follows Conventional Commits Guidelines
[x] PR Description is included
[ ] gif or screenshot is included if visual changes are made
[x] yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
[x] All checks have passed (DCO, Jenkins and Code Coverage)
[x] I have added unit test and it is passing
[ ] I have added integration test and it is passing
[ ] There is coverage for the code that I have added
[x] I have tested it manually and there are no regressions found

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.49%. Comparing base (4ad11e9) to head (21b9bc1).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2911 +/- ## ========================================== + Coverage 93.48% 93.49% +0.01% ========================================== Files 104 104 Lines 10869 10892 +23 Branches 2264 2272 +8 ========================================== + Hits 10161 10184 +23 Misses 707 707 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.