v3: Move DS Template storage setting

JillieBeanSim commented 1 month ago

Proposed changes

https://github.com/zowe/zowe-explorer-vscode/issues/2345

To Do:

[x] move setting out of ds history to "zowe.ds.templates"
[x] auto migration of setting from history to new, User setting only with migration as it was part of history
[x] add unit tests
[x] update v3 changes doc

If no workspace open when saving templates auto save to User Settings. If workspace open when saving templates, user if asked if they would like to save to User or Workspace Settings.

See Comment Below about migration testing

example history templates:

"templates": [
      {
        "newtst": {
          "alcunit": "CYL",
          "blksize": 6160,
          "dirblk": 10,
          "dsorg": "PO",
          "primary": 1,
          "recfm": "FB",
          "lrecl": 80
        }
      },
      {
        "newtst2": {
          "alcunit": "CYL",
          "blksize": 6160,
          "dirblk": 5,
          "dsorg": "PO",
          "primary": 1,
          "recfm": "FB",
          "lrecl": 80
        }
      }
  ]

Release Notes

Milestone: 3.0.0

Changelog:

ZE API:
- Breaking: Added return type of Promise<void> to IZoweTree.addDsTemplate. #2783.
ZE:
- BREAKING Moved data set templates out of data set history settings into new setting "zowe.ds.templates". #2345

Types of changes

What types of changes does your code introduce to Zowe Explorer? Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

[x] I have read the CONTRIBUTOR GUIDANCE wiki
[x] PR title follows Conventional Commits Guidelines
[x] PR Description is included
[x] gif or screenshot is included if visual changes are made
[x] yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
[x] All checks have passed (DCO, Jenkins and Code Coverage)
[x] I have added unit test and it is passing
[ ] I have added integration test and it is passing
[x] There is coverage for the code that I have added
[x] I have tested it manually and there are no regressions found
[x] I have added necessary documentation (if appropriate)
[ ] Any PR dependencies have been merged and published (if appropriate)

Further comments

https://github.com/zowe/zowe-explorer-vscode/assets/49491949/cc42d4f4-f0cc-426e-9056-c67721adf2ea

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 95.34884% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 92.68%. Comparing base (6370958) to head (f53e17d).

Files	Patch %	Lines
.../zowe-explorer/src/configuration/SettingsConfig.ts	81.81%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## next #2915 +/- ## ========================================== - Coverage 92.68% 92.68% -0.01% ========================================== Files 109 110 +1 Lines 10981 10994 +13 Branches 2314 2312 -2 ========================================== + Hits 10178 10190 +12 - Misses 801 802 +1 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 98.48485% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.65%. Comparing base (8900e58) to head (e1c8cca).

Files	Patch %	Lines
.../zowe-explorer/src/configuration/SettingsConfig.ts	81.81%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## next #2915 +/- ## ========================================== + Coverage 92.62% 92.65% +0.03% ========================================== Files 109 110 +1 Lines 11008 11044 +36 Branches 2347 2349 +2 ========================================== + Hits 10196 10233 +37 + Misses 810 809 -1 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.