search

zowe / zowe-explorer-vscode

Visual Studio Code Extension for Zowe, which lets users interact with z/OS Data Sets, Unix System Services, and Jobs on a remote mainframe instance. Powered by Zowe SDKs.
Eclipse Public License 2.0
159 stars 89 forks source link

Empty username in "Issue Command" actions is accepted input #2916

Open traeok opened 1 month ago

traeok commented 1 month ago

Describe the bug

When using one of the "Issue Command" actions, an empty username is considered valid input and is accepted by the input box.

To Reproduce

  1. Open the Command Palette and search for "Issue Command"
  2. Select one of the options (MVS, TSO or Unix)
  3. Select a profile to use for the command
  4. When the username prompt appears, press Enter
  5. Notice that the input box is dismissed, and although a "Operation Cancelled" message is shown (not pictured), the command moves to the next input box as if the action is still in progress.

Expected behavior

Add a validation function to the username input box to prevent users from submitting an empty username.

Screenshots

ZE-Empty-Username-IssueCmd

Desktop (please complete the following information):

Additional context

This is likely an issue within the logic for updating credentials as it only occurs for profiles that do not have any credentials stored.

github-actions[bot] commented 1 month ago

Thank you for creating a bug report. We will investigate the bug and evaluate its impact on the product. If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

shreyansh232 commented 1 month ago

I would like to resolve this issue, can you assign it to me?

traeok commented 1 month ago

I would like to resolve this issue, can you assign it to me?

@shreyansh232 Sure! I've assigned you to the issue 👍