Fix extender registration failure with multiple registrations

t1m0thyj commented 1 month ago

Proposed changes

Fixes #2888. To test this PR, install multiple extensions that contribute profiles to a ZE tree view (like the FTP extension and the USS sample extension). They should fail to load with ZE 2.15.4, but work with a VSIX built from this PR.

Release Notes

Milestone: 2.16.1?

Changelog: Fixed issue where multiple extensions that contribute profiles to a tree view using the Zowe Explorer API may fail to load

Types of changes

What types of changes does your code introduce to Zowe Explorer? Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

[x] I have read the CONTRIBUTOR GUIDANCE wiki
[ ] PR title follows Conventional Commits Guidelines
[x] PR Description is included
[ ] gif or screenshot is included if visual changes are made
[x] yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
[ ] All checks have passed (DCO, Jenkins and Code Coverage)
[ ] I have added unit test and it is passing
[ ] I have added integration test and it is passing
[ ] There is coverage for the code that I have added
[ ] I have tested it manually and there are no regressions found
[ ] I have added necessary documentation (if appropriate)
[ ] Any PR dependencies have been merged and published (if appropriate)

Further comments

Thanks @awharn for helping to write tests 😋

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.46%. Comparing base (2e898f3) to head (6f6b0d7). Report is 3 commits behind head on maintenance.

Files	Patch %	Lines
packages/zowe-explorer/src/Profiles.ts	50.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## maintenance #2919 +/- ## =============================================== - Coverage 93.49% 93.46% -0.03% =============================================== Files 104 104 Lines 10840 10840 Branches 2258 2370 +112 =============================================== - Hits 10135 10132 -3 - Misses 704 707 +3 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JillieBeanSim commented 1 month ago

Thanks @t1m0thyj for tackling this bug, I do see all registered types showing as available. I do see an issue with the FTP profile. I was prompted for credentials (user/pass in base for all) and zosmf and other prof type (rse used) ds filter search worked but the zftp kept having pop up with invalid creds

Sorry after more testing this credential issue exists on marketplace version as well. existing related issue https://github.com/zowe/zowe-explorer-vscode/issues/2337

JillieBeanSim commented 1 month ago

I think with 2.16.0 about to go out the door, we wait to merge this until after the release. We can discuss the plan of 2.16.1 and put together a list of fixes we want to include and when we would like it to go out, 1 week? 2 weeks?.

sonarcloud[bot] commented 1 month ago

Quality Gate failed

Failed conditions
14.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

zowe / zowe-explorer-vscode