search

zowe / zowe-explorer-vscode

Visual Studio Code Extension for Zowe, which lets users interact with z/OS Data Sets, Unix System Services, and Jobs on a remote mainframe instance. Powered by Zowe SDKs.
Eclipse Public License 2.0
159 stars 89 forks source link

Profile is added to tree even when quick pick is dismissed #2921

Open traeok opened 1 month ago

traeok commented 1 month ago

Describe the bug

When selecting a profile to add to a tree view, users are shown a follow-up prompt that asks if it should be added to all trees or just the selected one. However, if the quick pick is dismissed, it still adds the profile to the tree.

To Reproduce

  1. In one of the tree views, click the "+" button to add a profile
  2. Select a profile from the list
  3. When the follow-up prompt appears asking if it should be added to all trees, dismiss the prompt
  4. Notice that the profile was added anyway

Expected behavior

No profiles should be added if the quick pick is dismissed.

Screenshots

ZE-QuickPick-InvalidSelection

Desktop (please complete the following information):

Additional context

This might have been intended behavior when the feature was implemented, but it doesn't seem like an appropriate UX here. If we intend to fall back to this behavior when a user dismisses the quick pick, we should make it more obvious so that users are not confused when a profile is added after dismissing the prompt.

github-actions[bot] commented 1 month ago

Thank you for creating a bug report. We will investigate the bug and evaluate its impact on the product. If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.