Open crshnburn opened 1 month ago
Attention: Patch coverage is 26.15385%
with 48 lines
in your changes missing coverage. Please review.
Project coverage is 93.12%. Comparing base (
f0faba4
) to head (b0596f1
). Report is 2 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
...es/zowe-explorer/src/zosconsole/ZosConsolePanel.ts | 22.58% | 48 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@crshnburn, this is great. I agree with @JillieBeanSim's suggestions and would add two more, if possible:
Failed conditions
1 Security Hotspot
15.5% Duplication on New Code (required ≤ 3%)
D Security Rating on New Code (required ≥ A)
See analysis details on SonarCloud
Catch issues before they fail your Quality Gate with our IDE extension SonarLint
Tried a new build and the changes look good in terms of automatically adjusting the terminal size, scrolling to the bottom of command output, and the monospace font.
I really like the updates @crshnburn, I do still see some things on top of failing checks but can try to help address. My first try, I didn't realize I didn't have credentials tied to the profile and got an error vs the prompt so had to do filter search using profile in ZE to get prompted then went back to console and did a command that was successful but format didn't start new line with new command.
Proposed changes
Adds a new view into the panels area which allows a user to send operator commands to the selected z/OS Region and see the responses in a terminal type environment rather than having to use the Issue MVS Command option from the side panel each time.
Release Notes
Milestone:
Changelog: Add z/OS Console Panel
Types of changes
What types of changes does your code introduce to Zowe Explorer? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments