zowe / zowe-explorer-vscode

Visual Studio Code Extension for Zowe, which lets users interact with z/OS Data Sets, Unix System Services, and Jobs on a remote mainframe instance. Powered by Zowe SDKs.
Eclipse Public License 2.0
159 stars 89 forks source link

Contribute z/OS console panel #2925

Open crshnburn opened 1 month ago

crshnburn commented 1 month ago

Proposed changes

Adds a new view into the panels area which allows a user to send operator commands to the selected z/OS Region and see the responses in a terminal type environment rather than having to use the Issue MVS Command option from the side panel each time.

Release Notes

Milestone:

Changelog: Add z/OS Console Panel

Types of changes

What types of changes does your code introduce to Zowe Explorer? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

Further comments

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 26.15385% with 48 lines in your changes missing coverage. Please review.

Project coverage is 93.12%. Comparing base (f0faba4) to head (b0596f1). Report is 2 commits behind head on main.

Files Patch % Lines
...es/zowe-explorer/src/zosconsole/ZosConsolePanel.ts 22.58% 48 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2925 +/- ## ========================================== - Coverage 93.51% 93.12% -0.40% ========================================== Files 104 105 +1 Lines 10895 10961 +66 Branches 2388 2392 +4 ========================================== + Hits 10189 10207 +18 - Misses 705 753 +48 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adam-wolfe commented 1 month ago

@crshnburn, this is great. I agree with @JillieBeanSim's suggestions and would add two more, if possible:

sonarcloud[bot] commented 2 weeks ago

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
15.5% Duplication on New Code (required ≤ 3%)
D Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

adam-wolfe commented 2 weeks ago

Tried a new build and the changes look good in terms of automatically adjusting the terminal size, scrolling to the bottom of command output, and the monospace font.

JillieBeanSim commented 1 week ago

I really like the updates @crshnburn, I do still see some things on top of failing checks but can try to help address. My first try, I didn't realize I didn't have credentials tied to the profile and got an error vs the prompt so had to do filter search using profile in ZE to get prompted then went back to console and did a command that was successful but format didn't start new line with new command.

Screenshot 2024-06-19 at 2 29 01 PM