search

zowe / zowe-explorer-vscode

Visual Studio Code Extension for Zowe, which lets users interact with z/OS Data Sets, Unix System Services, and Jobs on a remote mainframe instance. Powered by Zowe SDKs.
Eclipse Public License 2.0
159 stars 89 forks source link

IApiRegisterClient.onProfilesDidUpdate() does not fire the UPDATE event when there are profile validation errors #2926

Open FrankSu1996 opened 1 month ago

FrankSu1996 commented 1 month ago

Describe the bug

If there are any profile validation errors, then IApiRegisterClient.onProfilesDidUpdate() does not fire the UPDATE event. Extenders need to know when any modifications occur to the team configuration file in order to properly sync with the ProfilesCache.

To Reproduce I'll be using rse profiles as an example to reproduce. Rse profiles require that a host attribute be defined and not an empty string.

  1. Make sure zopeneditor is installed.
  2. Create a new team configuration file, do not add any host value.
  3. Try modifying the team config file in any way (modify a profile name, attribute, etc)

Expected behavior

IApiRegisterClient.onProfilesDidUpdate() should fire the UPDATE event, but it doesn't. Extenders therefore cannot be notified of any attribute changes.

Screenshots

Desktop (please complete the following information):

Additional context

github-actions[bot] commented 1 month ago

Thank you for creating a bug report. We will investigate the bug and evaluate its impact on the product. If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

traeok commented 1 month ago

potentially related: https://github.com/zowe/zowe-explorer-vscode/issues/2822