Closed traeok closed 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.62%. Comparing base (
80d6e37
) to head (cfac68b
).:exclamation: Current head cfac68b differs from pull request most recent head 3af4923
Please upload reports for the commit 3af4923 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issues
3 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
2.5% Duplication on New Code
I do notice warnings about a broken lockfile when first running
pnpm install
with this branch. I believe last time we saw this was when pnpm 9 was used instead of 8 by the developer of the branch. I have 8.15.8. Still testing functionality but wanted to mention this. I see a lot of scripts/workflows using 9 but also seeengines: {pnpm: '>=8'}
in lockfile and deployment pulls 8 when doing search forpnpm
in repo. We can go to 9 but need to let all devs know to update
Sorry about that @JillieBeanSim, I was doing some tests with pnpm 9 and forgot to switch back to pnpm 8 - it ended up updating the lockfile to v9 as a result. I've addressed this in commit 3af4923 👍
Proposed changes
This pull request implements the following items:
How to test
tests/wdio-impl
branch in the ZE repopnpm install && pnpm build
at the root of the repopackages/zowe-explorer/__tests__/__e2e__/README.md
to prepare your environment for end-to-end testingcd packages/zowe-explorer && pnpm tests:e2e
to run testspackages/zowe-explorer/__tests__/__integration__/README.md
to ensure your environment is ready for integration testscd packages/zowe-explorer && pnpm tests:integration
to run testsBoth test scripts should succeed provided that:
__e2e__/.env
file refer to valid filters and items on the test system during the e2e testsIn addition, notice the new step in the build stage on Ubuntu/Node 20 titled "Integration tests" - these should be passing with the latest changes on this branch.
Release Notes
Milestone: v3
Changelog:
Types of changes
What types of changes does your code introduce to Zowe Explorer? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments
I noticed that we still had a few lint errors in the existing unit tests. I've corrected those as part of this branch.