zowe / zowe-explorer-vscode

Visual Studio Code Extension for Zowe, which lets users interact with z/OS Data Sets, Unix System Services, and Jobs on a remote mainframe instance. Powered by Zowe SDKs.
Eclipse Public License 2.0
159 stars 89 forks source link

tests: Behavior-driven integration and e2e tests using WebdriverIO #2927

Closed traeok closed 2 weeks ago

traeok commented 1 month ago

Proposed changes

This pull request implements the following items:

How to test

Both test scripts should succeed provided that:

In addition, notice the new step in the build stage on Ubuntu/Node 20 titled "Integration tests" - these should be passing with the latest changes on this branch.

Release Notes

Milestone: v3

Changelog:

Types of changes

What types of changes does your code introduce to Zowe Explorer? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

Further comments

I noticed that we still had a few lint errors in the existing unit tests. I've corrected those as part of this branch.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.62%. Comparing base (80d6e37) to head (cfac68b).

:exclamation: Current head cfac68b differs from pull request most recent head 3af4923

Please upload reports for the commit 3af4923 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #2927 +/- ## ========================================== - Coverage 92.63% 92.62% -0.01% ========================================== Files 109 109 Lines 11008 11008 Branches 2347 2343 -4 ========================================== - Hits 10197 10196 -1 - Misses 809 810 +1 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.5% Duplication on New Code

See analysis details on SonarCloud

traeok commented 2 weeks ago

I do notice warnings about a broken lockfile when first running pnpm install with this branch. I believe last time we saw this was when pnpm 9 was used instead of 8 by the developer of the branch. I have 8.15.8. Still testing functionality but wanted to mention this. I see a lot of scripts/workflows using 9 but also see engines: {pnpm: '>=8'} in lockfile and deployment pulls 8 when doing search for pnpm in repo. We can go to 9 but need to let all devs know to update

Sorry about that @JillieBeanSim, I was doing some tests with pnpm 9 and forgot to switch back to pnpm 8 - it ended up updating the lockfile to v9 as a result. I've addressed this in commit 3af4923 👍