Unable to open Favorited Job Search

SanthoshiBoyina1 commented 4 weeks ago

Proposed changes

To add the ability to open a Favorited Job Search under Favorites and as well as when the extension is reloaded.

Release Notes

Milestone:

Changelog:

Types of changes

What types of changes does your code introduce to Zowe Explorer? Put an x in the boxes that apply

[X] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

[x] I have read the CONTRIBUTOR GUIDANCE wiki
[x] PR title follows Conventional Commits Guidelines
[x] PR Description is included
[ ] gif or screenshot is included if visual changes are made
[x] yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
[ ] All checks have passed (DCO, Jenkins and Code Coverage)
[x] I have added unit test and it is passing
[ ] I have added integration test and it is passing
[x] There is coverage for the code that I have added
[ ] I have tested it manually and there are no regressions found
[ ] I have added necessary documentation (if appropriate)
[ ] Any PR dependencies have been merged and published (if appropriate)

Further comments

sonarcloud[bot] commented 4 weeks ago

Quality Gate failed

Failed conditions
31.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.50%. Comparing base (a320a65) to head (dd2abfb).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2930 +/- ## ========================================== - Coverage 93.52% 93.50% -0.02% ========================================== Files 104 104 Lines 10891 10890 -1 Branches 2354 2362 +8 ========================================== - Hits 10186 10183 -3 - Misses 704 706 +2 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zFernand0 commented 4 weeks ago

Hey @traeok and @JillieBeanSim, Should this be ported to vNext?

https://github.com/zowe/zowe-explorer-vscode/blob/next/packages/zowe-explorer/src/trees/job/ZoweJobNode.ts#L125

JillieBeanSim commented 4 weeks ago

@zFernand0, @traeok mentions in a comment that it is not needed on next branch

traeok commented 4 weeks ago

@zFernand0 That line points to the placeholder node that we show when expanding a profile in the Jobs tree w/o a filter, so that should be okay. I've made some adjustments in PR #2827 to address this specific case, so I don't believe this needs to be ported 👍

zFernand0 commented 4 weeks ago

😓 I should've read the whole history of the PR before going through the code. My apologies.

And thanks for clarifying 🙏🏽

JillieBeanSim commented 4 weeks ago

😓 I should've read the whole history of the PR before going through the code. My apologies.

And thanks for clarifying 🙏🏽

No worries, thanks for double checking. Better than it slipping through 😄

zowe / zowe-explorer-vscode