JillieBeanSim commented 3 weeks ago

Proposed changes

Update Zowe SDKs to 8.0.0-next.202405241828 and address breaking changes

2918

Release Notes

Milestone:

Changelog:

Types of changes

What types of changes does your code introduce to Zowe Explorer? Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

[ ] I have read the CONTRIBUTOR GUIDANCE wiki
[ ] PR title follows Conventional Commits Guidelines
[ ] PR Description is included
[ ] gif or screenshot is included if visual changes are made
[ ] yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
[ ] All checks have passed (DCO, Jenkins and Code Coverage)
[ ] I have added unit test and it is passing
[ ] I have added integration test and it is passing
[ ] There is coverage for the code that I have added
[ ] I have tested it manually and there are no regressions found
[ ] I have added necessary documentation (if appropriate)
[ ] Any PR dependencies have been merged and published (if appropriate)

Further comments

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 74.19355% with 8 lines in your changes missing coverage. Please review.

Project coverage is 92.62%. Comparing base (52e5de7) to head (9d217d8).

Files	Patch %	Lines
packages/zowe-explorer/src/utils/ProfilesUtils.ts	71.42%	8 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## next #2932 +/- ## ========================================== - Coverage 92.68% 92.62% -0.07% ========================================== Files 111 111 Lines 11017 11004 -13 Branches 2293 2347 +54 ========================================== - Hits 10211 10192 -19 - Misses 804 810 +6 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JillieBeanSim commented 3 weeks ago

@t1m0thyj I will be opening an issue in @zowe/cli for an issue I see where the converted configuration file isn't being written (tested on mac and windows with same results) and also if the code to delete the @zowe/secure-credential-store plugin isn't going to be public imperative should handle the check and removal in it's APIs

issue: https://github.com/zowe/zowe-cli/issues/2170

@zFernand0 I tested the config file creation with this PR and still see that the base profile is missing

t1m0thyj commented 3 weeks ago

@t1m0thyj I will be opening an issue in @zowe/cli for an issue I see where the converted configuration file isn't being written (tested on mac and windows with same results) and also if the code to delete the @zowe/secure-credential-store plugin isn't going to be public imperative should handle the check and removal in it's APIs

issue: zowe/zowe-cli#2170

@zFernand0 I tested the config file creation with this PR and still see that the base profile is missing

@JillieBeanSim Regarding the first issue, @gejohnston is investigating it.

Regarding the base profile missing, I pushed a commit that should fix this. It seems kind of redundant that the ConfigBuilder requires base profile definition to be passed in twice. Perhaps we could enhance the Zowe SDKs so that the old code would work 😋