zowe / zowe-explorer-vscode

Visual Studio Code Extension for Zowe, which lets users interact with z/OS Data Sets, Unix System Services, and Jobs on a remote mainframe instance. Powered by Zowe SDKs.
Eclipse Public License 2.0
159 stars 89 forks source link

Port 2.16.1 to Main #2933

Closed JillieBeanSim closed 3 weeks ago

JillieBeanSim commented 3 weeks ago

Proposed changes

port 2.16.1 changes to main

Release Notes

Milestone: n/a

Changelog: n/a

Types of changes

What types of changes does your code introduce to Zowe Explorer? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

Further comments

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.49%. Comparing base (d6d1c81) to head (c8d12f3).

Files Patch % Lines
packages/zowe-explorer/src/Profiles.ts 50.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2933 +/- ## ========================================== - Coverage 93.52% 93.49% -0.03% ========================================== Files 104 104 Lines 10890 10890 Branches 2370 2293 -77 ========================================== - Hits 10185 10182 -3 - Misses 704 707 +3 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JillieBeanSim commented 3 weeks ago

@t1m0thyj did you port that fix in 2.16.1 to next branch?

t1m0thyj commented 3 weeks ago

@t1m0thyj did you port that fix in 2.16.1 to next branch?

No, thanks for the reminder 😋 Will do it now.

sonarcloud[bot] commented 3 weeks ago

Quality Gate Failed Quality Gate failed

Failed conditions
14.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud