zowe / zowe-explorer-vscode

Visual Studio Code Extension for Zowe, which lets users interact with z/OS Data Sets, Unix System Services, and Jobs on a remote mainframe instance. Powered by Zowe SDKs.
Eclipse Public License 2.0
159 stars 89 forks source link

Fix downloading spool files failing to match tree nodes #2943

Closed t1m0thyj closed 2 weeks ago

t1m0thyj commented 3 weeks ago

Proposed changes

Fixes bug where nothing happens when trying to download spool files in the ZE jobs tree.

Release Notes

Milestone: 2.17.0

Changelog: Fixed issue where Download Spool action could fail to find spool files to download

Types of changes

What types of changes does your code introduce to Zowe Explorer? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

Further comments

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.48%. Comparing base (88a7257) to head (b58a6d6).

:exclamation: Current head b58a6d6 differs from pull request most recent head 1398351

Please upload reports for the commit 1398351 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## maintenance #2943 +/- ## ============================================ Coverage 93.48% 93.48% ============================================ Files 104 104 Lines 10842 10843 +1 Branches 2360 2371 +11 ============================================ + Hits 10136 10137 +1 Misses 705 705 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 2 weeks ago

Quality Gate Failed Quality Gate failed

Failed conditions
20.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

JillieBeanSim commented 2 weeks ago

@t1m0thyj do we have a ZE issue that can be tied to PR/milestone?

t1m0thyj commented 2 weeks ago

@JillieBeanSim I've created one: https://github.com/zowe/zowe-explorer-vscode/issues/2957