zowe / zowe-explorer-vscode

Visual Studio Code Extension for Zowe, which lets users interact with z/OS Data Sets, Unix System Services, and Jobs on a remote mainframe instance. Powered by Zowe SDKs.
Eclipse Public License 2.0
159 stars 89 forks source link

[cherry-pick] Add base profile when creating team config #2959

Closed JillieBeanSim closed 1 week ago

JillieBeanSim commented 2 weeks ago

Proposed changes

cherry-picked @t1m0thyj 's work in https://github.com/zowe/zowe-explorer-vscode/pull/2932 to solve a particular issue with base profile not being included in creation of config file

Release Notes

Milestone: 3.0.0-prerelease

Changelog: Fix issue with base profile not being included in fresh team configuration file. #2887

Types of changes

What types of changes does your code introduce to Zowe Explorer? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

Further comments

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.62%. Comparing base (1258565) to head (806cb82).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #2959 +/- ## ======================================= Coverage 92.62% 92.62% ======================================= Files 110 110 Lines 10985 10985 Branches 2250 2338 +88 ======================================= Hits 10175 10175 Misses 808 808 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

traeok commented 1 week ago

Changes LGTM, thanks @JillieBeanSim! Should be good to merge once conflicts are addressed.

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud