zowe / zowe-explorer-vscode

Visual Studio Code Extension for Zowe, which lets users interact with z/OS Data Sets, Unix System Services, and Jobs on a remote mainframe instance. Powered by Zowe SDKs.
Eclipse Public License 2.0
159 stars 89 forks source link

vNext: Port APIML login with PEM certificates #2964

Closed t1m0thyj closed 1 week ago

t1m0thyj commented 1 week ago

Proposed changes

Ports #2802 to next branch

Release Notes

Milestone: v3

Changelog:

Types of changes

What types of changes does your code introduce to Zowe Explorer? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

Further comments

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 92.40506% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.68%. Comparing base (73af1f1) to head (6bef5ab).

Files Patch % Lines
...kages/zowe-explorer/src/utils/CertificateWizard.ts 91.48% 4 Missing :warning:
...owe-explorer-api/src/vscode/ZoweVsCodeExtension.ts 91.30% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #2964 +/- ## ========================================== + Coverage 92.67% 92.68% +0.01% ========================================== Files 110 111 +1 Lines 10943 11017 +74 Branches 2274 2381 +107 ========================================== + Hits 10141 10211 +70 - Misses 800 804 +4 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 week ago

Quality Gate Failed Quality Gate failed

Failed conditions
4.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

zFernand0 commented 1 week ago

The failing checks in the Sample builds might be related to this issue.

https://github.com/vuejs/language-tools/issues/4487

Thanks @t1m0thyj and @traeok for your research on this.

Merging! 😋