search

zowe / zowe-explorer-vscode

Visual Studio Code Extension for Zowe, which lets users interact with z/OS Data Sets, Unix System Services, and Jobs on a remote mainframe instance. Powered by Zowe SDKs.
Eclipse Public License 2.0
170 stars 92 forks source link

FTP: Add test coverage for two remaining uncovered API methods #2989

Open adam-wolfe opened 3 months ago

adam-wolfe commented 3 months ago

Is your feature request related to a problem? Please describe.

For V2 compliance, there is a best practice to implement tests for all API methods. For the V2 FTP extension, two uncovered functions remain in /packages/zowe-explorer-ftp-extension/src/ZoweExplorerFtpJesApi.ts: https://github.com/zowe/zowe-explorer-vscode/blob/a2cff84ae183a23dd95c375ff19ddf240cffc91a/packages/zowe-explorer-ftp-extension/src/ZoweExplorerFtpJesApi.ts#L200 https://github.com/zowe/zowe-explorer-vscode/blob/a2cff84ae183a23dd95c375ff19ddf240cffc91a/packages/zowe-explorer-ftp-extension/src/ZoweExplorerFtpJesApi.ts#L204

The functions in question simply throw errors, so unit tests would have limited value; and, for compliance, this is only a best practice, not a requirement.

Describe the solution you'd like

Add unit test for these functions.

Describe alternatives you've considered

Additional context

github-actions[bot] commented 3 months ago

Thank you for raising this enhancement request. The community has 90 days to vote on it. If the enhancement receives at least 10 upvotes, it is added to our development backlog. If it receives fewer votes, the issue is closed.