zowe / zowe-explorer-vscode

Visual Studio Code Extension for Zowe, which lets users interact with z/OS Data Sets, Unix System Services, and Jobs on a remote mainframe instance. Powered by Zowe SDKs.
Eclipse Public License 2.0
173 stars 92 forks source link

Encoding not honored for spool files #3172

Closed VitGottwald closed 1 month ago

VitGottwald commented 1 month ago

Describe the bug

When I specify encoding in my z/OSMF profile it is honored for dataset retrieval/upload but not for spool file retrieval.

This is most likely because the following call does not take encoding into account https://github.com/zowe/zowe-explorer-vscode/blob/b43eccb8c6a0ac35b0cd6282d27afc65f7f9f3f7/packages/zowe-explorer/src/trees/job/JobActions.ts#L177

To Reproduce

  1. Set encoding in zosmf profle to ibm278
  2. Create a PDS member containing a nordic national character like Ö
  3. Print it to spool - e.g. via IEBGENER
  4. Open the PDS member and see Ö
  5. Open the spool file and see @

Expected behavior Encoding from zosmf profile is honored both for dataset and spool operations.

github-actions[bot] commented 1 month ago

Thank you for creating a bug report. We will investigate the bug and evaluate its impact on the product. If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

VitGottwald commented 1 month ago

The situation that I ran into this was when looking at a listing of a COBOL program that uses a nordic encoding.

JTonda commented 1 month ago

Closing in favor of #1941