search

zowe / zowe-explorer-vscode

Visual Studio Code Extension for Zowe, which lets users interact with z/OS Data Sets, Unix System Services, and Jobs on a remote mainframe instance. Powered by Zowe SDKs.
Eclipse Public License 2.0
173 stars 92 forks source link

TD: `pnpm build` may display TypeErrors during webpack #3298

Open zFernand0 opened 2 weeks ago

zFernand0 commented 2 weeks ago

Describe the bug

During our builds, you may find the following entry:

This likely happens due to an incompatibility between the TS version and one of the webpack plug-ins that we use

To Reproduce

Check out the CI lopgs

Expected behavior

No type error 😋

Stack-trace

Exception has occurred: TypeError: Cannot read properties of undefined (reading 'includes')
  at /Users/USER/gh/zowe/ze/node_modules/.pnpm/fork-ts-checker-webpack-plugin@9.0.2_typescript@5.6.3_webpack@5.96.1/node_modules/fork-ts-checker-webpack-plugin/lib/typescript/worker/lib/system.js:203:48
    at Array.some (<anonymous>)
    at isArtifact (/Users/USER/gh/zowe/ze/node_modules/.pnpm/fork-ts-checker-webpack-plugin@9.0.2_typescript@5.6.3_webpack@5.96.1/node_modules/fork-ts-checker-webpack-plugin/lib/typescript/worker/lib/system.js:203:29)
    at getReadFileSystem (/Users/USER/gh/zowe/ze/node_modules/.pnpm/fork-ts-checker-webpack-plugin@9.0.2_typescript@5.6.3_webpack@5.96.1/node_modules/fork-ts-checker-webpack-plugin/lib/typescript/worker/lib/system.js:208:66)
    at Object.getModifiedTime (/Users/USER/gh/zowe/ze/node_modules/.pnpm/fork-ts-checker-webpack-plugin@9.0.2_typescript@5.6.3_webpack@5.96.1/node_modules/fork-ts-checker-webpack-plugin/lib/typescript/worker/lib/system.js:75:23)
    at Object.getModifiedTime (/Users/USER/gh/zowe/ze/node_modules/.pnpm/fork-ts-checker-webpack-plugin@9.0.2_typescript@5.6.3_webpack@5.96.1/node_modules/fork-ts-checker-webpack-plugin/lib/typescript/worker/lib/host/watch-solution-builder-host.js:31:36)
    at getModifiedTime (/Users/USER/gh/zowe/ze/node_modules/.pnpm/typescript@5.6.3/node_modules/typescript/lib/typescript.js:7293:15)
    at getUpToDateStatusWorker (/Users/USER/gh/zowe/ze/node_modules/.pnpm/typescript@5.6.3/node_modules/typescript/lib/typescript.js:133378:102)
    at getUpToDateStatus (/Users/USER/gh/zowe/ze/node_modules/.pnpm/typescript@5.6.3/node_modules/typescript/lib/typescript.js:133587:18)
    at getNextInvalidatedProjectCreateInfo (/Users/USER/gh/zowe/ze/node_modules/.pnpm/typescript@5.6.3/node_modules/typescript/lib/typescript.js:133169:20)

Additional context

Source: https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/blob/main/src/typescript/worker/lib/system.ts#L286

github-actions[bot] commented 2 weeks ago

Thank you for creating a bug report. We will investigate the bug and evaluate its impact on the product. If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.