zowe / zowe-explorer-vscode

Visual Studio Code Extension for Zowe, which lets users interact with z/OS Data Sets, Unix System Services, and Jobs on a remote mainframe instance. Powered by Zowe SDKs.
Eclipse Public License 2.0
173 stars 92 forks source link

Fix flaky integration tests and error handling for invalid team config #3322

Closed t1m0thyj closed 5 days ago

t1m0thyj commented 1 week ago

Proposed changes

Fix transient errors in integration tests, and upload test results in CI even when tests fail to make debugging easier.

The tests passed 10 times in a row in this workflow: https://github.com/zowe/zowe-explorer-vscode/actions/runs/11923838338/job/33234787006

Also fixes error handling for an invalid team config file when ZE initializes, which was uncovered by fixing tests. In v3.0.3 the error notification was shown twice, and in the main branch ZE was failing to activate.

Release Notes

Milestone: 3.1.0

Changelog: Fixed an issue during initialization where the error dialog shown for a broken team configuration file was missing the "Show Config" action

Types of changes

Checklist

General

Code coverage

Deployment

Further comments

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.02%. Comparing base (57db6f3) to head (86a1b4e). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3322 +/- ## ========================================== + Coverage 92.99% 93.02% +0.03% ========================================== Files 116 116 Lines 12046 12046 Branches 2656 2773 +117 ========================================== + Hits 11202 11206 +4 + Misses 842 839 -3 + Partials 2 1 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

github-actions[bot] commented 1 week ago

📅 Suggested merge-by date: 12/4/2024

t1m0thyj commented 1 week ago

There is another integration test (UpdateCredentials.feature) that has frequent transient failures, marking as draft until this one is fixed.