zowe / zowe-explorer-vscode

Visual Studio Code Extension for Zowe, which lets users interact with z/OS Data Sets, Unix System Services, and Jobs on a remote mainframe instance. Powered by Zowe SDKs.
Eclipse Public License 2.0
173 stars 92 forks source link

fix(v2): Update migrated and recalled data sets in tree #3333

Open traeok opened 2 days ago

traeok commented 2 days ago

Proposed changes

Fixes the following issues:

Release Notes

Milestone: 2.18.1

Changelog:

Types of changes

Checklist

General

Code coverage

Deployment

traeok commented 2 days ago

"1 New Issue" is an existing problem with ZoweDatasetNode complexity. This should be resolved separately.

codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.37%. Comparing base (a5a0cd7) to head (38208d1).

Files with missing lines Patch % Lines
...kages/zowe-explorer/src/dataset/ZoweDatasetNode.ts 96.55% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## v2-lts #3333 +/- ## ========================================== + Coverage 93.36% 93.37% +0.01% ========================================== Files 105 105 Lines 11092 11109 +17 Branches 2426 2452 +26 ========================================== + Hits 10356 10373 +17 Misses 735 735 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

sonarcloud[bot] commented 2 days ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions[bot] commented 1 day ago

📅 Suggested merge-by date: 12/4/2024

traeok commented 1 day ago

Had a chance to test this and it seems to work well.

All things considered, LGTM! 😋

From an internal conversation 😋

The migration request is sent and the icon changes automatically (which could technically be wrong 😅) If I do the same dataset search, I still see it there (not-migrated) But that's just because of how migration/archival schedulers may be configured.

Thanks for testing Fernando and sorry for quickly dismissing your review 😅 I've addressed the behavior you mentioned where the icon changes right away. Now, we won't change the icon and we'll wait for it to be reflected when listing data sets.

traeok commented 1 day ago

Should we update the version of imperative/cli to get the updated cross-spawn 😋

LGTM! 😋

Once zowe-cli#2374 is merged, I'll bump the SDK/imperative versions in this PR 😁

zFernand0 commented 1 day ago

Should we update the version of imperative/cli to get the updated cross-spawn 😋 LGTM! 😋

Once zowe-cli#2374 is merged, I'll bump the SDK/imperative versions in this PR 😁

probably have to wait for the new cli version to be on public npm (tomorrow 🙏 )