zowe / zowe-explorer-vscode

Visual Studio Code Extension for Zowe, which lets users interact with z/OS Data Sets, Unix System Services, and Jobs on a remote mainframe instance. Powered by Zowe SDKs.
Eclipse Public License 2.0
171 stars 92 forks source link

User id and password field always shows up as "Optional" #803

Open venkatzhub opened 4 years ago

venkatzhub commented 4 years ago

Describe the bug

When creating a connection/profile without Userid and Password, the user is prompted for User id and Password when trying to do an operation (like search for a dataset) - which is the expected behavior. But the Userid and password dialog always shows as "Optional: User Name" and the text below says "Enter the user name for the connection. Leave blank to not store. (Press Enter to Confirm and Esc to Cancel)".

The User name and password when the user is trying to do an operation - are not optional. It also looks like the user name and password are not stored - i.e if I restart my VSCode instance, I'm prompted again - so the whole text is very misleading.

To Reproduce Steps to reproduce the behavior:

  1. Create a new connection/profile by using the + sign in the Zowe Explorer Datasets view.
  2. As part of the connection and profile creation process, specify the host name, host URL, but do not enter the user name, password - and choose False for Reject...
  3. Once the connection is created successfully, click on the search icon (magnifying glass) beside the connection, it prompts for User Name and Password - but they are labeled "Optional".

Expected behavior

The User name and password when the user is trying to do an operation are not optional, and the message that says the User name and password are stored is incorrect - so that needs to be fixed as well.

Screenshots

image

Desktop (please complete the following information):

Additional context

crawr commented 4 years ago

This is a duplicate of #744 . But we should probably keep this issue instead since it is better described here.

zFernand0 commented 4 years ago

Thanks @venkatzhub for describing the request in great details ❤️ Marked the issue as UX for now. This makes me think if maybe we should introduce a few more templates (e.g. general questions/dicussions, UX related changes, etc.)

venkatzhub commented 4 years ago

Sure @zFernand0 ! Irrespective of the labels, the key thing is to address it, and address it fast - as the functionality as advertised doesn't work.