zowe / zowe-install-packaging

Packaging repository for the Zowe install scripts and files
Eclipse Public License 2.0
27 stars 52 forks source link

manifest sourceDep check worflow #3806

Closed MarkAckert closed 5 months ago

MarkAckert commented 5 months ago

This PR adds a new workflow which will help detect sourceDependencies errors in the manifest.json.template. These errors were usually uncaught until RC branches where the sourceDependencies section becomes picked up by other automation, and as such the errors were always slow to find.

The idea is to validate sourceDependencies early, and check every repo+tag entry as both as a tag and a branch, since other automation can tolerate either. By convention, sourceDependencies for RC and release branches should be tags or commit hashes which pin down a specific build, so this automation's behavior will be stricter for PRs against RC/Main/Master branches.

This PR edited the following sourceDependencies sections from the manifest:

Test:

Against v2.x/staging with old orion branch. Expected=FAIL, Actual=FAIL. Against v2.x/staging. Expected=PASS, Actual=PASS. Against v2.x/rc: Expected=FAIL, Actual= FAIL (local test) Against v2.x/master: Expected=FAIL, Actual= FAIL (local test) Against v3.x/rc: Expected=FAIL, Actual= FAIL (local test)

github-actions[bot] commented 5 months ago

build 5082 CANCELLED. Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/8728048330

github-actions[bot] commented 5 months ago

build 5083 SUCCEEDED. Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/8728152906

github-actions[bot] commented 5 months ago

build 5084 SUCCEEDED. Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/8728176305

github-actions[bot] commented 5 months ago

build 5086 SUCCEEDED. Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/8728278676