zowe / zowe-install-packaging

Packaging repository for the Zowe install scripts and files
Eclipse Public License 2.0
27 stars 52 forks source link

Validation of keyring url is incorrect #3926

Open pj892031 opened 2 months ago

pj892031 commented 2 months ago

https://github.com/zowe/zowe-install-packaging/blob/07b929e02b1a20dc256b806ab35c055273faa61a/schemas/zowe-yaml-schema.json#L807

The validation assumes that the protocol is always safkeyring. It is not true since Java 11, it should allow at least safkeyringjce. Anyway, there are also other types, so the proper validation should be like ^safkeyring[a-z]*:\/\/.

There are workarounds:

1000TurquoisePogs commented 2 months ago

I confirm that zss and app-server both tolerate safkeyring. zss checks for `"safkeyring.://" app-server checks for"safkeyring.*"` So, a schema change here and use of java 11 names wont break them