zowe / zowe.github.io

Zowe.org website development
https://zowe.org
Creative Commons Attribution 4.0 International
12 stars 33 forks source link

Add floating menu button or goto top button. #44

Closed fbeyl closed 4 years ago

fbeyl commented 4 years ago

Pull down menu items cover content when pulled down and menu remains down after select. To go back to menu one has to go all the way back up or use the browser "go backwards one page", would be nice to have the menu button remain on top of viewport when scrolling down or have a goto top button remain at bottom.

fbeyl commented 4 years ago

@jmertic @jackjia-ibm Now @alexcontini added jquery I can use it to add 'goto top' button. Are there guideliness for colors to use? Is black the way to go (similar to the menu button) ? https://fbeyl.github.io/zowe.github.io/

jmertic commented 4 years ago

@alexcontini Can you comment here?

alexcontini commented 4 years ago

@fbeyl looks great! the only other color I would think of to use is the dark grey of the header or another grey, as blue will blend in when you scroll past those sections. I think black looks perfect

jmertic commented 4 years ago

Is this still active?

fbeyl commented 4 years ago

Had some issues with git (novice user ;) ), created pull request. Still 2 DCO errors.

jmertic commented 4 years ago

Hey - try these instructions...

https://github.com/zowe/zowe.github.io/pull/58/checks?check_run_id=252553438

Thank you,

John Mertic Director of Program Management - Linux Foundation ASWF, ODPi, and Open Mainframe Project jmertic@linuxfoundation.org +1 234-738-4571 Schedule time with me at https://calendly.com/jmertic

On Tue, Oct 8, 2019 at 2:44 PM fbeyl notifications@github.com wrote:

Had some issues with git (novice user ;) ), created pull request. Still 2 DCO errors.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zowe/zowe.github.io/issues/44?email_source=notifications&email_token=AACIOIMG2DU4SLWOBKID43LQNTIJZA5CNFSM4IPF5WS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAVGIJY#issuecomment-539649063, or mute the thread https://github.com/notifications/unsubscribe-auth/AACIOIOKZ3YCFCBOBHY25FLQNTIJZANCNFSM4IPF5WSQ .

fbeyl commented 4 years ago

Should be ok now.

jmertic commented 4 years ago

Closed with https://github.com/zowe/zowe.github.io/pull/58