zowe / zss

Zowe System Services Server for enabling low-level microservices
Eclipse Public License 2.0
13 stars 45 forks source link

Implement new attls toggle from new zowe json schema #611

Closed timgerstel closed 5 months ago

timgerstel commented 1 year ago

Proposed changes

This PR addresses Issue: [Link to Github issue within https://github.com/zowe/zss/issues if any]

This PR depends upon the following PRs:

Type of change

Please delete options that are not relevant.

PR Checklist

Please delete options that are not relevant.

Testing

Further comments

1000TurquoisePogs commented 1 year ago

Also you need a changelog when ready.

timgerstel commented 1 year ago

I think your conditionals are reversed, you need some !. http should exist when attls, and keyring should not. Right?

To be honest, the simpler way to do what you're doing is just to not change any components.zss.tls decision-making, and instead do

components.zss.tls == (zowe.network.attls || components.zss.launcher.attls) ? false : true

Using a ternary threw a linter error but i think i accomplished the same result anyway