zowe / zss

Zowe System Services Server for enabling low-level microservices
Eclipse Public License 2.0
13 stars 45 forks source link

Avoid using submodules because its annoying #633

Closed 1000TurquoisePogs closed 3 months ago

1000TurquoisePogs commented 1 year ago

It had been discussed that because we have a way of linking to different github places without use of submodules, we should just stop using submodules for zowe-common-c. submodules are annoying to everyone, so why not use our proj files instead?

ifakhrutdinov commented 1 year ago

Although I don't agree with the idea, you can already use submodules to track branches:

Setting things up:

git submodule set-branch --branch v2.x/staging -- zowe-common-c
git commit .gitmodule

Using it:

git clone --recursive git@github.com:zowe/zss.git
git submodule update --remote --recursive

This will bring the submodules to the latest state of their branches.

Briefly, I can see the following issues with both the approaches though:

I know there is an attitude of "who cares if staging breaks", but with this approach the amount of issues like that will likely increase. And breaking staging is not good either in my opinion. We have complicated authorized code that can potentially bring the system down because someone will update zowe-common-c without taking into account the state of the ZSS repo.

Could explain more how submodules make your development process more complicated and how are they annoying? Perhaps I can share tips and tricks that can make the issues go away.

Let's discuss this.