zowe / zss

Zowe System Services Server for enabling low-level microservices
Eclipse Public License 2.0
13 stars 45 forks source link

Use of IP addresses in project setup should be changed to github.com reference #660

Closed hogstrom closed 10 months ago

hogstrom commented 10 months ago

Describe the bug The zss configuration file build/zss.proj.env has the following references for support repos:

build/zss.proj.env:QUICKJS_SOURCE=“git@140.82.114.4:joenemo/quickjs-portable.git”
build/zss.proj.env:LIBYAML_SOURCE=“git@140.82.114.4:yaml/libyaml.git”

Is there a reason that there is an IP address specified for github rather than the dns entry github.com ?

Its a nit but I had to tweak my local ssh configuration to accomodate the IP address as a host to match my ssh keys.

Steps to Reproduce After cloning the repo and following the setup instructions attempt to build. You'll get

HOGSTRO@:M103>build.sh
********************************************************************************
Checking dependencies...
Checking dependencies in destination /u/hogstro/zowe/zss/build/.. using project file /u/hogstro/zowe/zss/build/../build/zss.proj.env
Dependencies=QUICKJS LIBYAML
Check if dir exist=/u/hogstro/zowe/zss/build/../deps/zss/quickjs
Clone: git@140.82.114.4:joenemo/quickjs-portable.git @ main to quickjs
Cloning into '/u/hogstro/zowe/zss/build/../deps/zss/quickjs'...
FOTS1373 git@140.82.114.4: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

This is caused by the use of IP address 140.82.114.4 rather than using the dns name github.com.

Expected behavior

HOGSTRO@:M103>build.sh
********************************************************************************
Checking dependencies...
Checking dependencies in destination /u/hogstro/zowe/zss/build/.. using project file /u/hogstro/zowe/zss/build/../build/zss.proj.env
Dependencies=QUICKJS LIBYAML
Check if dir exist=/u/hogstro/zowe/zss/build/../deps/zss/quickjs
Clone: git@github.com:joenemo/quickjs-portable.git @ main to quickjs
Cloning into '/u/hogstro/zowe/zss/build/../deps/zss/quickjs'...
remote: Enumerating objects: 361, done.
remote: Counting objects: 100% (361/361), done.
remote: Compressing objects: 100% (157/157), done.
remote: Total 361 (delta 225), reused 323 (delta 192), pack-reused 0
Receiving objects: 100% (361/361), 1.57 MiB | 684.00 KiB/s, done.
Resolving deltas: 100% (225/225), done.
Check if dir exist=/u/hogstro/zowe/zss/build/../deps/zss/libyaml
Clone: git@github.com:yaml/libyaml.git @ 0.2.5 to libyaml
Cloning into '/u/hogstro/zowe/zss/build/../deps/zss/libyaml'...
remote: Enumerating objects: 2192, done.
remote: Counting objects: 100% (23/23), done.
remote: Compressing objects: 100% (17/17), done.
Receiving objectsremote: Total 2192 (delta 3), reused 21 (delta 3), pack-reused 2169
Receiving objects: 100% (2192/2192), 1.43 MiB | 589.00 KiB/s, done.
Resolving deltas: 100% (1291/1291), done.

Describe your environment This is a 3-way ZD&T SYSPLEX running z/OS 2.4

Additional context This is more of a one time setup issue. The use of the IP address caused me to do a little research of what I was referencing so this is better hygeine.

I'll submit a PR to correct the issue.

1000TurquoisePogs commented 10 months ago

i agree. this was some bug on joe's side that also requires me to make the change.