zowe / zss

Zowe System Services Server for enabling low-level microservices
Eclipse Public License 2.0
13 stars 45 forks source link

Parmlib ZWESIP00: required prefix not validated by schema #705

Closed Martin-Zeithaml closed 3 months ago

Martin-Zeithaml commented 4 months ago

Make the handling of ZIS PARMLIB member less confusing for new users:

We should allow to change only what can be changed. We have to use such change to provide working STC.

For example:

JoeNemo commented 4 months ago

A pattern validation for YAML, or something similar, needs to be added to the JSON schema

Martin-Zeithaml commented 4 months ago

Schema validation

Part of 3718.

Templating

ZWEIMVS

For testing purposes, ZWE_ and zowe. used.

//SYSIN DD *
  COPY OUTDD=SYSUT2,INDD=SYSUT1
  SELECT MEMBER=((ZWESIP00,{ZWE_zowe_setup_dataset_parmlibMembers_zis},R))
  SELECT MEMBER=((ZWESIP00,{zowe.setup.dataset.parmlibMembers.zis},R))
//*

If the zis not set, it will return:

//SYSIN DD *
  COPY OUTDD=SYSUT2,INDD=SYSUT1
  SELECT MEMBER=((ZWESIP00,CFG.ZWE_ZOWE_SETUP_DATASET_PARMLIBMEMBERS_ZIS,R))
  SELECT MEMBER=((ZWESIP00,CFG.ZOWE.SETUP.DATASET.PARMLIBMEMBERS.ZIS,R))
//*

ZWESISTC

How to set just suffix via JCL templating? //ZWESIS01 PROC NAME='ZWESIS_STD',MEM=00,RGN=0M

JoeNemo commented 4 months ago

@jordanfilteau1995 Are you willing to take an enhancement request to support some string manipluation in the templating logic?

Martin-Zeithaml commented 4 months ago

ZWESISTC update

It is even more complicated, we are supporting customization of the name via components.zss.crossMemoryServerName.

We need to have ability to template this with yaml or default values:

//ZWESIS01  PROC NAME='{components.zss.crossMemoryServerName or ZWESIS_STD}',
//   MEM={substring of zowe.setup.dataset.parmlibMembers.zis or 00},RGN=0M
JoeNemo commented 4 months ago

@1000TurquoisePogs will be adding this to defaults and this will probably close the issue.

JoeNemo commented 4 months ago

Since this bug is not reported as affecting anyone in the outside world, we can probably do this in the course of V3 work.